Matteo/gql #14
Merged
Matteo/gql #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # readme.md
didimitrie
reviewed
Jul 29, 2020
| async streams( parent, args, context, info ) { | ||
| await validateScopes( context.scopes, 'streams:read' ) | ||
|
|
||
| if ( args.limit && args.limit > 100 ) |
There was a problem hiding this comment.
The discussion around max limits & default limits:
- max limits should be implemented everywhere that returns a collection (so we don't get stuff like
limit: 1000000to potentially crash UIs - default limits: should be a wee bit more conservative, depending on the perceived user-land usage:
- e.g. commits: we can potentially display a longer list, so it can be higher (50?)
- e.g. streams: i don't think more than 20-ish? 25? would comfortably fit on a page before you need to switch to either a search or a "next page".
Another note, if we want to be lenient, we could just return the default max limit rather than throw an error, but I guess it's good to inform the dev 👍
There was a problem hiding this comment.
Ok, changed all the defaults to 25. Will keep the error as IMHO it's a better experience than having to open the docs and check why out of my ~123 streams only 100 are showing (happened to me in he past).
…ranches & commits. Additional changes as per PR #14.
|
@didimitrie should be all done! |
didimitrie
approved these changes
Jul 29, 2020
|
Yay then merge away. Feels so formal doing code reviews :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds userSearch and streamSearch